Skip to content

feat: update the DevTools 2 lesson of the JS2 course to be about JavaScript #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

honzajavorek
Copy link
Collaborator

A part of #1584

@honzajavorek honzajavorek requested a review from TC-MO June 27, 2025 13:52
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Jun 27, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 59675ea and is ready at https://pr-1655.preview.docs.apify.com!

@@ -135,7 +135,7 @@ We'll expand the result by clicking the small arrow, then hover our cursor over

![Highlighting a querySelectorAll() result](./images/devtools-hover-queryselectorall.png)

To save the subwoofer in a variable for further inspection, we can use index access with brackets, just like in Python lists (or JavaScript arrays):
To save the subwoofer in a variable for further inspection, we can use index access with brackets, just like with Python lists (or JavaScript arrays):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous lines you've erased Python mention and made JS first and center, any reason why here it is different?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is a bug!

Copy link
Collaborator Author

@honzajavorek honzajavorek Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! It is not 😄 This is a fix of one word in a corresponding Python lesson, so the wording is correct here (but would, of course, be incorrect in the files above). I should probably mark these ad-hoc fixes in the Python course, as they're a bit confusing when reading the diffs. It's not easy to keep the context of "actually, this is in scraping_basics_python folder" and when I saw your comment for the first time, I didn't realize it myself 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah you are right :D Didn't even occur to me to double check the file names :D Mea Culpa!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's impossible to spot. I'll add warning signs next time ⚠️ 🐍

@honzajavorek honzajavorek requested a review from TC-MO July 28, 2025 10:59
@honzajavorek honzajavorek merged commit e0ac59f into master Jul 28, 2025
10 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/js2-devtools2 branch July 28, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants