-
Notifications
You must be signed in to change notification settings - Fork 129
feat: update the DevTools 2 lesson of the JS2 course to be about JavaScript #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview for this PR was built for commit |
 | ||
|
||
To save the subwoofer in a variable for further inspection, we can use index access with brackets, just like in Python lists (or JavaScript arrays): | ||
To save the subwoofer in a variable for further inspection, we can use index access with brackets, just like with Python lists (or JavaScript arrays): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In previous lines you've erased Python mention and made JS first and center, any reason why here it is different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this is a bug!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! It is not 😄 This is a fix of one word in a corresponding Python lesson, so the wording is correct here (but would, of course, be incorrect in the files above). I should probably mark these ad-hoc fixes in the Python course, as they're a bit confusing when reading the diffs. It's not easy to keep the context of "actually, this is in scraping_basics_python
folder" and when I saw your comment for the first time, I didn't realize it myself 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah you are right :D Didn't even occur to me to double check the file names :D Mea Culpa!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it's impossible to spot. I'll add warning signs next time
A part of #1584